Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributors and LICENSE file #85

Merged
merged 1 commit into from
May 26, 2020

Conversation

olivier-stasse
Copy link
Member

Add contributors (maybe the name of the organization should be fixed to reflect when people made their contributions)
Fix #20

@olivier-stasse olivier-stasse mentioned this pull request May 10, 2020
@nim65s
Copy link
Contributor

nim65s commented May 10, 2020

I'm not sure this contributors file is useful. We already have:

  1. a section in the README
  2. metadata in package.xml
  3. git history

@olivier-stasse
Copy link
Member Author

Thanks Guilhem. You are right. It is now removed.

@nim65s
Copy link
Contributor

nim65s commented May 10, 2020

Ok, thanks. I'll mark this PR as a draft, to avoid its merge, as we should fix #76 first.
Then, we should not merge it without an history rewrite, as there is a commit that creates a file, and another one that deletes it. A squash should be enough.

@nim65s nim65s marked this pull request as draft May 10, 2020 09:26
Removed CONTRIBUTORS file.
From a remark of Guilhem Saurel that this is rightfully redundant.
@nim65s nim65s marked this pull request as ready for review May 26, 2020 14:44
@nim65s nim65s merged commit d715c10 into stack-of-tasks:devel May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants