Adds first version of krustlet based agent implementation #18

soenkeliebau · 2020-11-26T07:42:16Z

This is the first code drop for the agent version that has been based on the Krustlet code.

Implemented functionality is:

register node with apiserver and keep the node alive
watch for pods
upon pod assigned:
- download package
- install package
- backoff on missing config map
- create config from config maps
- start process
- wait for process to not die during startup
- watch process for the runtime

…ngs.

…mitations of the config parsing that Krustlet does. Krustlet does not allow building a config from scratch by just specifying a few values, so we override some values by setting environment variables from our config - BUT: it is not currently possible to specify command line parameters when starting the agent, as the Krustlet will also try to parse these and doesn't know about them, so the only possible way to pass arguments is currently via exporting a config file in the CONFIG_FILE env variable and specifying all arguments in there. An example has been added in config/agent_config

…started.

lfrancke

Not done yet with the review.
Will continue tomorrow.

Cargo.toml

src/main.rs

src/provider/states/download_package_backoff.rs

src/provider/states/download_package.rs

src/provider/states/install_package.rs

src/provider/repository/stackablerepository.rs

src/provider/states/install_package.rs

src/provider/states/stopped.rs

src/provider/states/stopping.rs

src/provider/states/waiting_config.rs

src/provider/states.rs

config/agent_config

src/provider/repository/package.rs

src/provider/states/creating_config.rs

src/provider/repository/stackablerepository.rs

src/provider/states/creating_config.rs

src/provider/repository/mod.rs

src/provider/error.rs

src/provider/mod.rs

src/main.rs

lfrancke

Almost there 👍
There are also still a few things open/unresolved from past reviews.

src/provider/states/failed.rs

src/provider/mod.rs

src/provider/repository/mod.rs

src/provider/states/create_service.rs

src/provider/states/downloading.rs

src/provider/states/starting.rs

src/provider/states/stopped.rs

src/provider/states/stopping.rs

One remaining for dead code, but this is called from a test case.

…d some dead code.

lfrancke

Looks good! Thank you!

soenkeliebau added 8 commits November 23, 2020 15:40

Working version after move from external project.

9ca6de7

Added cargo.lock to repo

5ec1579

Added current version of code and started refactoring to remove warni…

e7de3a0

…ngs.

Fixed majority of linter warnings.

cc38098

Fixed rest of linter warnings except "unused variable" ones.

6570313

Added code to look up the default IP.

b7cae72

soenkeliebau requested review from lfrancke, fwaibel and iamatwork November 26, 2020 07:42

Added code to properly set containers to _ready_ when the process is …

f572bd2

…started.

This was linked to issues Nov 26, 2020

Ability to replace path variables in generated config #14

Closed

Ability to download and unpack packages #15

Closed

Ability to keep pod in waiting state until all referenced configmaps have been created #16

Closed

Added handling of environment variables in container section of pod.

9cbbae6

lfrancke suggested changes Nov 26, 2020

View reviewed changes

soenkeliebau added 2 commits November 26, 2020 17:41

Add debug statement for env vars.

2cf0207

More debug statements.

03ce6b1

lfrancke suggested changes Nov 27, 2020

View reviewed changes

lfrancke linked an issue Nov 27, 2020 that may be closed by this pull request

Implement configuration management #12

Closed

lfrancke assigned soenkeliebau Nov 27, 2020

soenkeliebau added 2 commits December 1, 2020 16:36

Addressed comments from Lars.

3847d0d

Forgot to address comments in main.rs.

4115e5c

lfrancke suggested changes Dec 1, 2020

View reviewed changes

lfrancke reviewed Dec 1, 2020

View reviewed changes

src/main.rs Show resolved Hide resolved

soenkeliebau added 2 commits December 2, 2020 10:10

Second round of review comments by Lars addressed.

68dfb0f

Fix rustfmt complaints.

3852c54

soenkeliebau requested a review from lfrancke December 2, 2020 09:40

lfrancke suggested changes Dec 2, 2020

View reviewed changes

soenkeliebau added 3 commits December 2, 2020 12:11

Hopefully last remnants

51ba044

Removed unneeded static annotation

cc6781c

Fixed clippy suggestions.

1f0b7a8

One remaining for dead code, but this is called from a test case.

soenkeliebau requested a review from lfrancke December 2, 2020 11:47

soenkeliebau added 3 commits December 2, 2020 15:58

Changed a few occurrences of illegal container status reasons, remove…

6f44e10

…d some dead code.

Fixed unused variable

5a7245b

Linter warning

26b7824

lfrancke approved these changes Dec 2, 2020

View reviewed changes

soenkeliebau merged commit 2e6e52f into stackabletech:main Dec 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds first version of krustlet based agent implementation #18

Adds first version of krustlet based agent implementation #18

soenkeliebau commented Nov 26, 2020 •

edited

Loading

lfrancke left a comment

lfrancke left a comment

lfrancke left a comment

Adds first version of krustlet based agent implementation #18

Adds first version of krustlet based agent implementation #18

Conversation

soenkeliebau commented Nov 26, 2020 • edited Loading

lfrancke left a comment

Choose a reason for hiding this comment

lfrancke left a comment

Choose a reason for hiding this comment

lfrancke left a comment

Choose a reason for hiding this comment

soenkeliebau commented Nov 26, 2020 •

edited

Loading