Skip to content

Conversation

siegfriedweber
Copy link
Member

Closes #88

@siegfriedweber siegfriedweber force-pushed the rebase_superset_image_on_ubi branch from a9ee50e to 5e5612d Compare April 28, 2022 11:19
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor point (relating to usage rather than the image build itself): the image names now have a python element to them so the example in the operator should have a corresponding change e.g. 1.4.1-python39 rather than just 1.4.1. Likewise with the cluster version names in the integration tests.

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re. comment about image names - I missed the fact that the build script will take care of this!
LGTM.

@siegfriedweber siegfriedweber merged commit 4f8cce0 into main May 2, 2022
@siegfriedweber siegfriedweber deleted the rebase_superset_image_on_ubi branch May 2, 2022 07:46
bors bot pushed a commit to stackabletech/superset-operator that referenced this pull request May 2, 2022
## Description

The location of the Superset configuration file was changed in the Superset product image version 2 (see stackabletech/docker-images#103). The location was adapted and the required version set to 2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base Superset image on the Red Hat UBI
2 participants