Skip to content

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Sep 24, 2025

Description

Follow up to #1231. Missed a line in there, this PR fixes it.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@xeniape xeniape self-assigned this Sep 24, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Sep 24, 2025
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that makes sense, I assume this is the reason all NodePorts broke.
Feel free to test if this really fixes things, but also happy to merge optimistically as we want this fix in any case

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 25, 2025
@xeniape xeniape added this pull request to the merge queue Sep 25, 2025
Merged via the queue into main with commit f59d843 Sep 25, 2025
3 checks passed
@xeniape xeniape deleted the fix/fix-NIFI-14858-patch branch September 25, 2025 06:07
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Sep 25, 2025
@sbernauer
Copy link
Member

Patch me baby one more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants