ci(build): Add runners selection #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the build succeeds with the set of Ubicloud runners specified in the JSON file.
Techassi
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
NickLarsenNZ
previously approved these changes
Oct 8, 2025
There was a problem hiding this comment.
LGTM, probably also need to update https://github.com/stackabletech/docker-images/blob/main/.github/actionlint.yaml
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Huh, that file would indeed need updating, but we are already using a runner which is not listed in there and it seems like there are no complaints. I assume this is because we use the matrix to set the I can update the file anyway. |
This reverts commit de22cd1. This needs to be reverted, because it doesn't pass CI even though it passes locally for me. With this reverted, it will fail locally again. This is very curious, because any differences in file sorting sue to different shells should be accounted for by the bash shebang in the script.
|
I will merge this at CoB, because this will trigger a rebuild of all images. |
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Successful test runs:
With this PR, container image build pipelines can now select one of the following set of runners:
mixed: x86_64 builds run on the GitHub hosted runners and the aarch64 builds run on the Ubicloud runnersubicloud: Both the x86_64 and the aarch64 builds run on the Ubicloud runnersThis PR is raised to fix the OpenSearch Dashboards build on x86_64. It is very likely that this feature will be removed or adjusted in the future when the set of available/used runners changes.