Skip to content

Conversation

Maleware
Copy link
Member

Description

As found during release.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@lfrancke
Copy link
Member

Can you change to uname while we're at it?

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maleware Maleware added this pull request to the merge queue Jul 23, 2024
@NickLarsenNZ NickLarsenNZ assigned Maleware and unassigned Maleware Jul 23, 2024
Merged via the queue into main with commit c0acf35 Jul 23, 2024
14 checks passed
@Maleware Maleware deleted the fix/release-pipeline branch July 23, 2024 16:29
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Jul 23, 2024

Retagged with

git push origin :24.7.0
git tag -d 24.7.0

git log -1 # ensure HEAD is the correct commit. Else use a commit hash:
git tag --no-sign -m "release 24.7.0" 24.7.0 
git push --follow-tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants