Skip to content

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Oct 14, 2024

Description

This fixes build errors where java-22-openjdk-* packages are no longer available.

  • Use temurin JDK/JRE.
  • Install findutils in stackable-base (remove from dependent images).
    • TODO: Update the comments with vulnerability search information
  • Add a shell.nix for installing developer dependencies.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [x] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@NickLarsenNZ NickLarsenNZ self-assigned this Oct 14, 2024
@Techassi Techassi self-requested a review October 14, 2024 11:47
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Techassi <sascha.lautenschlaeger@stackable.tech>
Techassi
Techassi previously approved these changes Oct 15, 2024
Co-authored-by: Lars Francke <lars.francke@stackable.tech>
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 8ea476e Oct 15, 2024
2 checks passed
@NickLarsenNZ NickLarsenNZ deleted the migrate-temurin-java branch October 15, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants