-
-
Notifications
You must be signed in to change notification settings - Fork 13
Rework the Lifecycle policies page #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
IMO the extremly personal style of this text damages clarity and simplicity. I mean formulations like "our products", "your Kubernetes resources" are pretty vague and don't read very professional. Also there is a bit of callout inflation, like for example:
As a reader I have to wonder: as opposed to what? I know this is a a bit of style preference so I don't expect you to agree. |
I believe I have fixed all comments and also tried to address some of the feedback from @razvan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - just one nit.
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor suggestion.
Co-authored-by: Techassi <git@techassi.dev>
No description provided.