Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 17, 2025

Description

Follow-up of #657.
https://testing.stackable.tech/job/hdfs-operator-it-weekly/48/ and https://testing.stackable.tech/job/hdfs-operator-it-weekly/49/ took more than 6 hours, so longern than our replicated cluster TTL, thus failing

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] CRD documentation for all fields, following the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible
# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated. Follows the [style guide](https://docs.stackable.tech/home/nightly/contributor/docs/style-guide).
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This honestly should be blocked. The tests shouldn't take ages to complete and we must test all supported versions without cutting back on the overall scope of testing to "ship around" this issue.

@NickLarsenNZ
Copy link
Member

This honestly should be blocked. The tests shouldn't take ages to complete and we must test all supported versions without cutting back on the overall scope of testing to "ship around" this issue.

IMO, this one is fine for 25.3.0. Zookeeper barely changes between patch versions, and should be backward compatible anyway.

We can work on optimising tests after the release so that we don't need to make these sacrifices again.

@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: In Review in Stackable Engineering Mar 20, 2025
@Techassi
Copy link
Member

I'm fine with removing it for now (to unblock the 25.3.0 release), but we should really investigate how we can improve test run times.

@sbernauer
Copy link
Member Author

+1 on both of you, thanks!

@sbernauer sbernauer added this pull request to the merge queue Mar 20, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 20, 2025
Merged via the queue into main with commit 0728a20 Mar 20, 2025
16 of 17 checks passed
@sbernauer sbernauer deleted the test/reduce-number branch March 20, 2025 09:50
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants