Skip to content

[Merged by Bors] - Delete orphaned cluster resources #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Delete orphaned cluster resources #254

wants to merge 9 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 10, 2022 •
edited by siegfriedweber
Loading

Description

fixes #157

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/11/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Oct 10, 2022
@maltesander maltesander marked this pull request as ready for review October 10, 2022 15:43
@siegfriedweber siegfriedweber self-requested a review October 11, 2022 11:19
siegfriedweber
siegfriedweber requested changes Oct 11, 2022
View reviewed changes
@maltesander @siegfriedweber
Update CHANGELOG.md
01697a2 
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
@siegfriedweber
Copy link
Member

The dependency to serde_yaml can be removed and the crd command in main.rs can be implemented as follows:

    match opts.cmd {
        Command::Crd => HiveCluster::print_yaml_schema()?,

siegfriedweber
siegfriedweber approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 12, 2022
@maltesander
Delete orphaned cluster resources (#254)
8650862 
# Description

fixes #157

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/hive-operator-it-custom/11/



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 12, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Delete orphaned cluster resources [Merged by Bors] - Delete orphaned cluster resources Oct 12, 2022
@bors bors bot closed this Oct 12, 2022
@bors bors bot deleted the orphaned_resources branch October 12, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle stale information/clean up stale resources
2 participants
@maltesander @siegfriedweber