Skip to content

chore(issue_templates): Add labels task to early pre-release list #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Aug 4, 2025

This PR adds a "create release related labels" task to the list of early pre-release tasks.

@Techassi Techassi requested a review from NickLarsenNZ August 4, 2025 07:03
@Techassi Techassi self-assigned this Aug 4, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a suggestion

@Techassi Techassi requested a review from NickLarsenNZ August 4, 2025 07:31
Comment on lines +39 to +40
[epr-1]: https://github.com/stackabletech/infrastructure/blob/main/label_sync/labels.yml#L93
[epr-2]: https://github.com/stackabletech/infrastructure/blob/main/label_sync/labels.yml#L107
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There either needs to be a single commit chosen, or no line numbers.
Using a branch and line numbers will eventually drift.

I would suggest using main, and therefore not use line numbers (which unfortunately means going back to a single link0. Although, I don't mind keeping them as permalinks if the line numbering is important.

Suggested change
[epr-1]: https://github.com/stackabletech/infrastructure/blob/main/label_sync/labels.yml#L93
[epr-2]: https://github.com/stackabletech/infrastructure/blob/main/label_sync/labels.yml#L107
[epr-1]: https://github.com/stackabletech/infrastructure/blob/79729860858db5939fed1aeb5d9f15e7d507cfb5/label_sync/labels.yml#L93
[epr-2]: https://github.com/stackabletech/infrastructure/blob/79729860858db5939fed1aeb5d9f15e7d507cfb5/label_sync/labels.yml#L107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants