-
-
Notifications
You must be signed in to change notification settings - Fork 8
fix(docs): Update getting-started script pre-25.7.0 #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Successfully tested
|
NickLarsenNZ
commented
Jul 15, 2025
NickLarsenNZ
commented
Jul 15, 2025
After adding indentation, I realised that this could affect the presentation of the script snippets in the rendered docs
sbernauer
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
I like that it's now much shorter.
Pls still feel free to switch back to multi-step endpoint gathering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check and Update Getting Started Script
Part of stackabletech/issues#742
Note
During a Stackable release we need to check (and optionally update) the
getting-started scripts to ensure they still work after product and operator
updates.