Skip to content

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Apr 11, 2024

  • the build action does not run anymore on docs and README changes
  • the check_readme job has been pulled into its own file with seperate scope to only run on README changes

@fhennig fhennig self-assigned this Apr 11, 2024
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fhennig fhennig marked this pull request as ready for review April 11, 2024 09:02
@fhennig fhennig added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit 8dde343 Apr 11, 2024
@fhennig fhennig deleted the feat/narrower-github-action-scopes branch April 11, 2024 09:03
fhennig pushed a commit that referenced this pull request Apr 11, 2024
@fhennig
Copy link
Contributor Author

fhennig commented Apr 11, 2024

We tried it, didn't work because if required checks don't run, the whole PR can't be merged. This is at least somewhat known: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks but there is no good fix immediately available.

github-merge-queue bot pushed a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants