feat: Add EoS checker #644
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
approved these changes
Oct 6, 2025
| // type: string | ||
| pub fn tls_key_length_schema(_: &mut schemars::gen::SchemaGenerator) -> Schema { | ||
| pub fn tls_key_length_schema(_: &mut SchemaGenerator) -> Schema { | ||
| serde_json::from_value(serde_json::json!({ |
There was a problem hiding this comment.
We could use the new schemars macro for that
| // NOTE (@Techassi): I'm not quite sure if there is any benefit to pinning these futures | ||
| // to the stack (maybe slightly better performance), but it was there before and as such | ||
| // we will keep it. | ||
| pin!(csi_server, truststore_controller, eos_checker); |
There was a problem hiding this comment.
I think previously the pin was needed, now not any more. We also removed it in other PRs IIRC
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#733. This adds the EoS checker to the operator.