This repository was archived by the owner on Feb 16, 2024. It is now read-only.
[Merged by Bors] - Airflow cron-DAG demo #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Many thanks, demo works fine! Sorry for pushing commits, but i rebased it to main (Some internal stuff i did change on main) and fixed the nav.adoc. Website now renders fine
Only minor doc comments left. I like they way you mark your screenshots :)
Only remaining thing is maybe the name of the demo. I have the feeling that cron and dag don't make too much sense for newbies. What do you think about e.g. airflow-scheduling, airflow-scheduled-job. But i don't have a strong feeling
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
approved these changes
Sep 13, 2022
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
## Description A simple Airflow demo showing how to import/load a custom DAG and schedule it by enabling and triggering it. Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A simple Airflow demo showing how to import/load a custom DAG and schedule it by enabling and triggering it.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information