feat: exclude Feedback component from SSR #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
✅ Deploy Preview for stackblitz-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fvsch
commented
Oct 30, 2023
Comment on lines
+10
to
+12
| <ClientOnly> | ||
| <Feedback /> | ||
| </ClientOnly> |
There was a problem hiding this comment.
My understanding is that the <ClientOnly> component is globally registered and does not need to be imported. (It's not exported from 'vitepress' either.) Seems to work in my tests. I wish the VitePress docs were clearer about that.
ykmsd
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR wraps the
Feedbackcomponent, which relies on client-side UI and JS to save user feedback, within VitePress'sClientOnlycomponent.This avoids generating the base HTML structure of this component in the VitePress build, and showing buttons that don't work when JavaScript is not loaded. It might also be a tiny SEO improvement, though it’s probably trivial.
Self-check
Please check all that apply:
Contributors list
Would you like your contribution to be celebrated? Please check all that apply:
I would like to be featured on the future contributors list in the README. If so, please tell us:
I would like to get a shoutout in the next monthly updates post. If so, please provide your twitter handle (or we will link to your GitHub profile).
⚡️ ⚡️ ⚡️ Thank you for contributing to StackBlitz ⚡️ ⚡️ ⚡️