Skip to content

fix(react): allow preview panel to be fully collapsed #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

fix(react): allow preview panel to be fully collapsed #445

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c411f3
fix(react): allow preview panel to be fully collapsed
isaacplmann Apr 11, 2025
d118a4b
Merge branch 'main' into minimize-preview-panel
AriPerkkio Apr 14, 2025
f5fcd31
Merge branch 'main' into minimize-preview-panel
isaacplmann Apr 14, 2025
9bf1bf5
fix(react): calculate min size from static pixel size
isaacplmann Apr 15, 2025
a54374a
fix: typings
AriPerkkio Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions packages/react/src/Panels/WorkspacePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function WorkspacePanel({ tutorialStore, theme, dialog }: Props) {
const terminalExpanded = useRef(false);

return (
<PanelGroup className={resizePanelStyles.PanelGroup} direction="vertical">
<PanelGroup className={resizePanelStyles.PanelGroup} id="right-panel-group" direction="vertical">
<DialogProvider value={dialog}>
<EditorSection
theme={theme}
Expand Down Expand Up @@ -237,11 +237,32 @@ function PreviewsSection({
return () => unsubscribe();
}, [storeRef]);

const MIN_SIZE_IN_PIXELS = 38;
const [panelMinSize, setPanelMinSize] = useState(10);

useEffect(() => {
const panelGroup = document.querySelector('div[data-panel-group-id="right-panel-group"]' as 'div');

if (!panelGroup) {
return;
}

const observer = new ResizeObserver(() => {
const height = panelGroup?.offsetHeight;
setPanelMinSize((MIN_SIZE_IN_PIXELS / height) * 100);
});
observer.observe(panelGroup);

return () => {
observer.disconnect();
};
}, []);

return (
<Panel
id={hasPreviews ? 'previews-opened' : 'previews-closed'}
defaultSize={hasPreviews ? 50 : 0}
minSize={10}
minSize={panelMinSize}
maxSize={hasPreviews ? 100 : 0}
collapsible={!hasPreviews}
className={classNames({
Expand Down