feat: add eslint #90
feat: add eslint #90
Conversation
|
|
|
|
Updated the PR to use the alpha version that was released. |
package.json
Outdated
| @@ -11,11 +11,13 @@ | |||
| "docs:build": "pnpm run --filter=tutorialkit.dev build", | |||
| "demo": "pnpm run --filter=demo.tutorialkit.dev dev", | |||
| "demo:build": "pnpm run --filter=demo.tutorialkit.dev build", | |||
| "lint": "eslint \"{packages,docs}/**/*.{ts,tsx,js,json,jsonc,js,mjs,cjs}\"", | |||
There was a problem hiding this comment.
Is eslint covering prettier as well?
Any reason we don't include all files and folders?
There was a problem hiding this comment.
Yes, our eslint plugin always included the eslint recommended rules and it also takes the prettier config into account.
Any reason we don't include all files and folders?
I only did this to reduce the number of files to be checked and to be more specific. Other than that there's no particular reason. Cause those extensions are the only files that our plugin covers, but I think it would be fine to remove the extensions since the plugin contains the file extensions too and it would ignore other files.
| import { TutorialStore } from '@tutorialkit/runtime'; | ||
| import { auth, WebContainer } from '@webcontainer/api'; | ||
| import { useAuth } from './setup.js'; |
There was a problem hiding this comment.
Oh this import should always be first as it sets a global read by the @webcontainer/api package.
Deploying tutorialkit-demo-page with
|
| Latest commit: |
35e23d8
|
| Status: | 🚫 Build failed. |
This PR adds our eslint plugin to enforce our coding convention across the monorepo.
I have already fixed all linting issues that were reported and streamlined some of the CSS files as well to match our conventions. We should definitely add some style (CSS, SCSS) linting as well at some point.
ℹ️
Note that running this won't work as of right now because the new version of the eslint plugin is not yet published.✅