Use megaparsec 6.0 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpaucar
force-pushed
the
use_megaparsec_6
branch
from
18907dd
to
65a30d3
Compare
juanpaucar
force-pushed
the
use_megaparsec_6
branch
2 times, most recently
from
737ba2e
to
07ebc72
Compare
sebashack
reviewed
Aug 1, 2017
| @@ -141,5 +142,5 @@ spec = describe "parse" $ do | |||
| it "doesn't allow more configuration options after a quoted value" $ | |||
| parseConfig `shouldFailOn` "foo='bar'baz='buz'" | |||
|
|
|||
| parseConfig :: String -> Either (ParseError Char Dec) [ParsedVariable] | |||
| parseConfig :: String -> Either (ParseError Char Void) [ParsedVariable] | |||
There was a problem hiding this comment.
@juanpaucar could you just tell me why the type Dec changed to Void?
There was a problem hiding this comment.
Because as mentioned in he first part of the documentation I defined a type alias for parser type Parser = Parsec Void String and ParseError must keep the same type. So, in this case it would be Void
sestrella
requested changes
Aug 1, 2017
dotenv.cabal
Outdated
| @@ -55,7 +55,7 @@ executable dotenv | |||
| , base-compat >= 0.4 | |||
| , dotenv >= 0.3.1.0 | |||
| , optparse-applicative >=0.11 && < 0.15 | |||
| , megaparsec >= 5.0 && < 6.0 | |||
| , megaparsec >= 5.0 && < 7.0 | |||
There was a problem hiding this comment.
@juanpaucar I think you need to increase the lower boundary as well.
dotenv.cabal
Outdated
| @@ -75,11 +75,14 @@ library | |||
|
|
|||
| build-depends: base >=4.6 && <5.0 | |||
| , base-compat >= 0.4 | |||
| , megaparsec >= 5.0 && < 6.0 | |||
| , megaparsec >= 5.0 && < 7.0 | |||
juanpaucar
force-pushed
the
use_megaparsec_6
branch
from
07ebc72
to
6fdcec8
Compare
juanpaucar
force-pushed
the
use_megaparsec_6
branch
from
6fdcec8
to
6c26814
Compare
juanpaucar
force-pushed
the
use_megaparsec_6
branch
from
6c26814
to
f3c000b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commercialhaskell/stackage#2666