out.py: prefer stderr and remove isatty() restriction #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In POSIX tradition, informational messages that are not essential output belong on stderr. Semantically, it appears as if both .info() and .note() are used for such messages, so switch them to that stream.
Now that more messages print to stderr, we don't have to play guardian with the stdout file descriptor.
Pull Request Test Coverage Report for Build 59
💛 - Coveralls |
|
I think this looks great. Thanks for making it happen. I'd like to give @ctmarinas a chance to veto this if there is some historical context we might be missing. Otherwise, I'll merge this in the next couple days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this is good enough for now to close #35.
By changing .info() and .note() to stderr, we can slacken the isatty() restriction and get away with no test breakages. Seems fairly clean; though of course this is still a change in behavior that might break fragile scripts.