Add support for changing libvirt socket and pid path #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to use an uncontainerised libvirtd alongside a containerised instance which has bind mounted /var/run/libvirt into the container.
This stops us having to keep the default in sync with the virt modules.
This was used for testing
This improves readability
Reflects the fact that we are not *just* setting the pid file
The libvirt-bin.service file sources /etc/default/libvirt-bin as an environment file.
future plays require the daemon to be started
jovial
changed the title
markgoddard
reviewed
Nov 15, 2018
README.md
Outdated
| `/var/run/{{ libvirt_host_var_prefix }}` if `libvirt_host_var_prefix` is set, | ||
| otherwise `""`. | ||
|
|
||
| `libvirt_host_pid_path`: Path to PID file which prevents mulitple instances of |
vars/Debian.yml
Outdated
| insertafter: '^#libvirtd_opts=' | ||
| regexp: '^libvirtd_opts=' | ||
| line: libvirtd_opts="{{ libvirt_host_libvirtd_args }}" | ||
| condition: "{{ libvirt_host_libvirtd_args != '' }}" |
There was a problem hiding this comment.
Interesting approach here. Probably more code than two tasks with when RedHat/Debian, but would extend well to adding further options.
The libvirt-bin package has been removed in modern releases
markgoddard
approved these changes
Nov 16, 2018
| --- | ||
|
|
||
| - name: Determine path to libvirt environment file | ||
| # On Debian >= 8 and Ubuntu >= 16.04 the libvirt-bin package has been |
There was a problem hiding this comment.
We do have this condition elsewhere, so presumably we could extract it into a variable and set the path based on the variable. This works though.
tasks/config.yml
Outdated
| become: True | ||
|
|
||
| - name: Flush handlers | ||
| meta: flush_handlers |
There was a problem hiding this comment.
There is a chance that we could get here without the daemon running, if none of the above tasks are changed. To be certain, you can add a service/state=started task after flushing handlers.
|
Has a merge conflict |
As Mark suggested, it is possible that the handlers may not run - libvirt could then be stopped at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to use an uncontainerised libvirtd alongside
a containerised instance which has bind mounted /var/run/libvirt
into the container.