-
Notifications
You must be signed in to change notification settings - Fork 19
Allow arbitrary hostnames #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI the molecule tests pass and also deployed a basic slurm cluster which also appears to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor observation on the README content. I tested it with OpenHPC2 and CentOS 8 - there's some work to do there but I ran on top of this branch and it all seemed good.
In due course it would be neat to make a python filter to find run-length encodings from an arbitrary list of hostnames!
Run Molecule tests in Travis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
List nodes and nodes in partitions in
slurm.conf
using ansible inventory group contents rather than assuming they follow the patterncluster_name-group_name-{0..num_nodes-1}
. This allows compute nodes to have arbitrary hostnames.I think this addresses #3 in a more flexible way than the current code.
Note that:
num_nodes
is no longer required & will be ignored if provided.NodeName=DEFAULT
which is recommended to improve scheduler performance.master
branch with escaped line-ends ifram_mb
is not provided andgroup_hosts
is empty.Tested (manually, and now via Molecule running locally with different node/partition/group names - this is not yet in Travis) on cases: