Skip to content

Fix token templating in API deployment #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix token templating in API deployment #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eb8053
Fix conditional bug in API deployment templating
sd109 May 9, 2024
00d4865
Fix conditional checks for HF tokens
sd109 May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions chart/templates/api/deployment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,14 @@ spec:
{{- if .Values.huggingface.secretName }}
envFrom:
- secretRef:
name: huggingface-token
{{- else if .Values.huggingface.token }}
name: {{ .Values.huggingface.secretName }}
{{- end }}
env:
- name: DO_NOT_TRACK
value: 1
value: "1"
{{- if .Values.huggingface.token }}
- name: HUGGING_FACE_HUB_TOKEN
value: {{ quote .Values.huggingface.token }}
{{- else if contains "Llama" .Values.huggingface.model -}}
{{- fail "Either secretName or token value must be set for Llama and other gated models" }}
{{- end }}
readinessProbe:
httpGet:
Expand All @@ -60,4 +59,4 @@ spec:
- name: shm
emptyDir:
medium: Memory
sizeLimit: 1Gi
sizeLimit: 1Gi