Use container's system CA trust store #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
added a commit
to stackhpc/kayobe-automation
that referenced
this pull request
Apr 11, 2024
The tempest_cacert variable may specify the CA certificate path. Depends on stackhpc/docker-rally#16
Previously it was not possible to use this image in an environment with a CA that is not trusted by the Python trust store. This is because the rally-verify-wrapper.sh script unset any OS_CACERT environment variable (presumably assuming any CA cert would not necessarily be available in the container). This change makes it possible to bind mount CA certificates in the container under /usr/local/share/ca-certificates/ and have them added to the system trust store and used by Rally/Tempest. In this case, OS_CACERT is set automatically. If there are no certificates in /usr/local/share/ca-certificates/, we revert to the previous behaviour of unsetting OS_CACERT.
mnasiadka
approved these changes
Apr 15, 2024
markgoddard
added a commit
to stackhpc/kayobe-automation
that referenced
this pull request
Apr 15, 2024
The tempest_cacert variable may specify the CA certificate path. Depends on stackhpc/docker-rally#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to use this image in an environment with
a CA that is not trusted by the Python trust store. This is because the
rally-verify-wrapper.sh script unset any OS_CACERT environment variable
(presumably assuming any CA cert would not necessarily be available in
the container).
This change makes it possible to bind mount CA certificates in the
container under /usr/local/share/ca-certificates/ and have them added
to the system trust store and used by Rally/Tempest. In this case,
OS_CACERT is set automatically.
If there are no certificates in /usr/local/share/ca-certificates/, we
revert to the previous behaviour of unsetting OS_CACERT.