Skip to content

Conversation

Wasaac
Copy link

@Wasaac Wasaac commented Nov 20, 2019

Backporting for Stein. Upstream here: https://review.opendev.org/#/c/676185/
Change-Id: I472af9ec8cee3462beb5aca04ea6171b79933abe

@Wasaac Wasaac self-assigned this Nov 20, 2019
@Wasaac Wasaac requested review from dougszumski and brtkwr November 20, 2019 15:45
brtkwr
brtkwr previously approved these changes Nov 21, 2019
Copy link

@brtkwr brtkwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth passing -x argument to the cherrypick for provenance but otherwise lgtm.

Change-Id: I472af9ec8cee3462beb5aca04ea6171b79933abe
(cherry picked from commit 1a93e88)
@Wasaac
Copy link
Author

Wasaac commented Nov 21, 2019

Might be worth passing -x argument to the cherrypick for provenance but otherwise lgtm.

Cheers @brtknr. Pushed again following your advice.

@Wasaac Wasaac requested a review from brtkwr November 21, 2019 14:08
@Wasaac Wasaac merged commit c1c198d into stackhpc/stein Nov 21, 2019
@Wasaac Wasaac deleted the monasca_grafana_app_stein branch November 21, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants