Skip to content

Conversation

jovial
Copy link

@jovial jovial commented Jun 5, 2020

markgoddard and others added 2 commits June 5, 2020 14:09
Includes pep8, py27 and docs tox environments.

Change-Id: Id260e641d6b282806fb5b62781b4aa756bf1cb2c
(cherry picked from commit fa2afb8)
Change-Id: I472af9ec8cee3462beb5aca04ea6171b79933abe
(cherry picked from commit 1a93e88)
(cherry picked from commit 791cc7a)
@jovial jovial requested review from brtkwr and Wasaac June 5, 2020 13:17
@jovial
Copy link
Author

jovial commented Jun 5, 2020

@Wasaac I noticed that https://review.opendev.org/#/c/676185/ isn't passing CI - do we still want it or should we wait for it to land in master?

@Wasaac
Copy link

Wasaac commented Jun 5, 2020

@Wasaac I noticed that https://review.opendev.org/#/c/676185/ isn't passing CI - do we still want it or should we wait for it to land in master?

CI appeared to use a custom npm registry lacking one of the components needed. So far it's worked for us but I should push to get the tests passed upstream instead.

@dougszumski dougszumski self-requested a review June 6, 2020 13:31
@jovial jovial merged commit aac07a0 into merge-upstream-train Jun 8, 2020
@markgoddard markgoddard deleted the merge-upstream-train-picks-from-stein branch September 15, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants