Synchronise yoga with upstream #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
According to the documentation the first argument to log is either a domain or a '.' (dot). The current setting of 'log stdout' appears to blackhole query logs. The default output of log is stdout so the argument would not be necessary. Removing `stdout` allows coredns to send query logs to stdout. Reference: https://coredns.io/plugins/log/ Change-Id: I7837015c37eb58ba43ff42cc8b647c717fa1c650 (cherry picked from commit e4e0843)
If the kubelet container is restarted on a host (during upgrades, or manually) the bind mounts duplicate into /rootfs and kubelet cannot unmount these. This leads to stuck terminating pods that must be resolved with either --force or restart of kubelet container. Adding 'rslave' means that when the kubelet unmounts volumes at /var/lib/kubelet/pods this propogates to the host (using 'rshared'), and back into the container in /rootfs. This bug was likely introduced when mounting of /rootfs was added[0]. [0] https://opendev.org/openstack/magnum/commit/1994e9448a4d131e6305b68e49f1fdcdb5420cef Change-Id: I44f80ccc97c0eeab98f1edbe4a22763732b7f4da (cherry picked from commit b318560) (cherry picked from commit ed63a0d626b030f7d5fa81fe3341b7e8d8ef4a2b)
github-actions
bot
added
automated
mnasiadka
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of yoga from upstream.