Skip to content

Synchronise yoga with upstream #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Synchronise yoga with upstream #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions nova/tests/unit/compute/test_compute_mgr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7615,6 +7615,24 @@ def test_validate_instance_group_policy_handles_hint_list(self, mock_get):
instance, hints)
mock_get.assert_called_once_with(self.context, uuids.group_hint)

@mock.patch('nova.objects.InstanceGroup.get_by_hint')
def test_validate_instance_group_policy_deleted_group(self, mock_get):
"""Tests that _validate_instance_group_policy handles the case
where the scheduler hint has a group but that group has been deleted.
This tests is a reproducer for bug: #1890244
"""
instance = objects.Instance(uuid=uuids.instance)
hints = {'group': [uuids.group_hint]}
mock_get.side_effect = exception.InstanceGroupNotFound(
group_uuid=uuids.group_hint
)
# FIXME(sean-k-mooney): this should not leak the exception
self.assertRaises(
exception.InstanceGroupNotFound,
self.compute._validate_instance_group_policy, self.context,
instance, hints)
mock_get.assert_called_once_with(self.context, uuids.group_hint)

@mock.patch('nova.objects.InstanceGroup.get_by_uuid')
@mock.patch('nova.objects.InstanceList.get_uuids_by_host')
@mock.patch('nova.objects.InstanceGroup.get_by_hint')
Expand Down