Send flavor resources as value metadata #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue where the resources dimension could contain a string with prohibited characters, for example: "VCPU:64, MEMORY_MB:393216, DISK_GB:110, None". This change moves the flavor resource string to the value_meta field which has fewer restrictions over the content. If we later want to index resources as a function of the flavor resource fields, for example CPU count, we could add those as separate dimensions on the metric.
Move the usage summary from a dimension to the value_meta for the same reasons as the flavor resources.
This caused the Monasca API to reject the metric.
This should fix the servers per user and number of servers days per user graphs so that they work out of the box.
JohnGarbutt
added a commit
that referenced
this pull request
Nov 2, 2017
Add flag to skip looking at custom resource class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where the resources dimension could
contain a string with prohibited characters, for example:
"VCPU:64, MEMORY_MB:393216, DISK_GB:110, None".
This change moves the flavor resource string to the value_meta
field which has fewer restrictions over the content. If we
later want to index resources as a function of the flavor
resource fields, for example CPU count, we could add those
as separate dimensions on the metric.