Skip to content

added proper templating section #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2023
Merged

added proper templating section #9

merged 1 commit into from
Mar 29, 2023

Conversation

g0rgamesh
Copy link
Contributor

No description provided.

jovial
jovial approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me

JohnGarbutt
JohnGarbutt reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the dashboard here is for use with the import command, and that works and has been tested.

With kolla wee push it in via disk. Don't we need to update ${DS_PROMETHEUS} as well to make that work?

@g0rgamesh g0rgamesh merged commit 0f3030f into master Mar 29, 2023
@g0rgamesh
Copy link
Contributor Author

So the dashboard here is for use with the import command, and that works and has been tested.

With kolla wee push it in via disk. Don't we need to update ${DS_PROMETHEUS} as well to make that work?

It's been tested without updating ${DS_PROMETHEUS}, and it worked.

@JohnGarbutt
Copy link
Member

@g0rgamesh have you tested it still work via the UI when you import it please?

@JohnGarbutt JohnGarbutt mentioned this pull request Mar 29, 2023
Merged
@g0rgamesh g0rgamesh mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnGarbutt JohnGarbutt JohnGarbutt left review comments

@jovial jovial jovial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g0rgamesh @JohnGarbutt @jovial