Skip to content

Quick and dirty fix for duplicate storage metrics #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Quick and dirty fix for duplicate storage metrics #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c612ad
Fix duplicate storage devices
jovial Mar 4, 2025
cfc13a9
...
jovial Mar 4, 2025
cd3650f
Address comments from code review
jovial Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion collector/system_collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,11 +347,23 @@ func (s *SystemCollector) Collect(ch chan<- prometheus.Metric) {
} else if simpleStorages == nil {
systemLogContext.WithField("operation", "system.SimpleStorages()").Info("no simple storage data found")
} else {
processed := make(map[string]bool)
for _, simpleStorage := range simpleStorages {
devices := simpleStorage.Devices
wg8.Add(len(devices))
for _, device := range devices {
go parseDevice(ch, systemHostName, device, wg8)
_, exists := processed[device.Name]
if exists {
systemLogContext.WithField("operation",
"system.SimpleStorages()").Info(fmt.Sprintf("Ignoring " +
"duplicate storage device: %s. Please check whether this " +
"device is returning duplicate data and report to the vendor.",
device.Name))
wg8.Done()
continue
}
go parseDevice(ch, systemHostName, device, wg8)
processed[device.Name] = true
}
}
}
Expand Down