Quick and dirty fix for duplicate volume metrics #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoteHue
force-pushed
the
bugfix/storage-volume
branch
3 times, most recently
from
1d3b25c to
b66d548
Compare
Same fix as in #6
Builds were failing with the rc-bullseye release: 0.525 /go/src/github.com/stackhpc/redfish_exporter/go.mod:5: unknown directive: toolchain 0.526 make: *** [Makefile:35: build] Error 1
MoteHue
force-pushed
the
bugfix/storage-volume
branch
from
b66d548 to
d56a725
Compare
dougszumski
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Many thanks @MoteHue - this looks good.
We could really use test coverage for mocking all the different HW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as in #6