Skip to content

Conversation

markgoddard
Copy link
Contributor

No description provided.

@markgoddard markgoddard requested a review from a team as a code owner August 17, 2022 09:28
@markgoddard markgoddard self-assigned this Aug 17, 2022
.. code-block:: console
sudo apt update
sudo apt install python3-virtualenv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not also be beneficial to add acl as a required package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I'm not sure where is the right place to install that package. Ansible docs suggest it happens when using become and become_user with an unprivileged user, which is not that common. Still, it might be useful to install the package in Kayobe.

In fact, we already do, just in a specific code path that you didn't hit:

# NOTE(mgoddard): The acl package is required for the setfacl command, used by
# become_user.
- name: Ensure acl package is installed
  package:
    name: acl
    cache_valid_time: "{{ apt_cache_valid_time if ansible_facts.os_family == 'Debian' else omit }}"
    update_cache: "{{ True if ansible_facts.os_family == 'Debian' else omit }}"
  become: true

So we could move that code somewhere more general.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markgoddard markgoddard merged commit e7775cb into stackhpc/wallaby Aug 17, 2022
@markgoddard markgoddard deleted the readme-fix branch August 17, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants