Support filtering Kolla container images to sync/publish #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can take a long time to sync and publish all Kolla container images to the local Pulp service. Sometimes we know we just need to update a few images. This change adds support for filtering the image list, using regexes in a similar way to kolla-build. Example: kayobe playbook run ... -e stackhpc_pulp_images_kolla_filter='"^glance nova-compute$"'
jovial
reviewed
Aug 31, 2022
| - redis-base | ||
| - redis-sentinel | ||
|
|
||
| # Whitespace-separated list of regular expressions matching Kolla image names. |
There was a problem hiding this comment.
White space separated matches what we have in https://github.com/stackhpc/stackhpc-release-train/pull/121/files. Not related to this PR, as none of the image names contain anyway whitespace, but I had the sudden realisation that this means that the short names for the repositories can't have any whitespace in.
There was a problem hiding this comment.
That's correct.
jovial
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can take a long time to sync and publish all Kolla container images
to the local Pulp service. Sometimes we know we just need to update a
few images. This change adds support for filtering the image list, using
regexes in a similar way to kolla-build.
Example:
kayobe playbook run ... -e stackhpc_pulp_images_kolla_filter='"^glance nova-compute$"'