Skip to content

Conversation

assumptionsandg
Copy link
Contributor

@assumptionsandg assumptionsandg requested a review from a team as a code owner January 21, 2025 14:37
@product-auto-label product-auto-label bot added size: l ansible Ansible playbooks documentation Improvements or additions to documentation workflows Workflow files have been modified labels Jan 21, 2025
@Alex-Welsh
Copy link
Member

@assumptionsandg is this ready for review?

@MoteHue
Copy link
Contributor

MoteHue commented Jan 30, 2025

The client side of this works, have tested in a prod system 👍

assumptionsandg and others added 7 commits February 10, 2025 15:01
Co-authored-by: Alex-Welsh <112560678+Alex-Welsh@users.noreply.github.com>
Co-authored-by: Alex-Welsh <112560678+Alex-Welsh@users.noreply.github.com>
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last little comments. I think we should be able to get this merged today

assumptionsandg and others added 2 commits February 11, 2025 15:25
Co-authored-by: Matt Anson <matta@stackhpc.com>
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just be sure to squash when you merge

@Alex-Welsh Alex-Welsh dismissed stale reviews from bbezak and MoteHue February 13, 2025 13:45

Done

Copy link
Member

@seunghun1ee seunghun1ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on client staging system

@assumptionsandg assumptionsandg enabled auto-merge (squash) February 13, 2025 14:14
@Alex-Welsh Alex-Welsh disabled auto-merge February 13, 2025 14:50
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hypervisor crashes have been observed with this setup on a prod system, lets hold off on merging for now

@MoteHue
Copy link
Contributor

MoteHue commented Feb 18, 2025

Hypervisor crashes have been observed with this setup on a prod system, lets hold off on merging for now

We've been able to recreate the crashes with the inbox driver, so it seems to be an issue with SRIOV+RL9.5 at this specific site.

So imo this doesn't need to block this PR anymore.

@Alex-Welsh Alex-Welsh merged commit 9f0d85a into stackhpc/2024.1 Feb 18, 2025
14 checks passed
@Alex-Welsh Alex-Welsh deleted the ofed-fixes branch February 18, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible playbooks documentation Improvements or additions to documentation size: l workflows Workflow files have been modified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants