Skip to content

Conversation

seunghun1ee
Copy link
Member

  • Added Prerequisite section about using Python 3.12
  • Removed Known issue section of Let's Encrypt because the issue was resolved

@seunghun1ee seunghun1ee self-assigned this Aug 27, 2025
@seunghun1ee seunghun1ee requested a review from a team as a code owner August 27, 2025 10:21
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @seunghun1ee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the upgrading-openstack.rst documentation to reflect current requirements and resolved issues. It introduces a new prerequisite section for Python 3.12, outlining its necessity for OpenStack 2025.1 and providing clear instructions for environment setup. Concurrently, an outdated 'Let's Encrypt' known issue section has been removed, streamlining the documentation and ensuring its accuracy.

Highlights

  • Python 3.12 Prerequisite: A new section has been added to the upgrade documentation detailing the requirement for Python 3.12 for OpenStack 2025.1. This includes instructions for installing Python 3.12 on Ubuntu 24.04 and Rocky Linux 9, and guidance on creating new Python virtual environments for Kayobe and Kolla-Ansible.
  • Resolved Let's Encrypt Issue: The 'Let's Encrypt' known issue section has been removed from the documentation. This issue, which previously described a breaking change related to TLS settings, has been resolved, making the documentation obsolete.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Epoxy upgrade documentation. It correctly removes the 'Let's Encrypt' known issue, which is now resolved. It also adds a new prerequisite section for Python 3.12, which is a necessary change for the OpenStack 2025.1 release. I've found a couple of minor issues in the new section, including a typo and a small grammar suggestion to improve clarity. Overall, the changes are good and improve the documentation.

@mnasiadka
Copy link
Member

Should we think about documenting to use beokay? I'd guess majority of us and our clients use that.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a note to the Upgrading local Kayobe environment section please? It should also mention something about python 3.12, even if that's just a link back to this new section.

While you're there, i noticed a typo in the last line of the first paragraph of that section (uprade), would you mind fixing that?

@seunghun1ee
Copy link
Member Author

We have https://stackhpc-kayobe-config.readthedocs.io/en/stackhpc-2025.1/usage.html#beokay but not utilised well I guess.
I can try referencing this for generating new python venv?

@Alex-Welsh
Copy link
Member

We have https://stackhpc-kayobe-config.readthedocs.io/en/stackhpc-2025.1/usage.html#beokay but not utilised well I guess. I can try referencing this for generating new python venv?

That would be good. We should try to normalise as many sites as possible on beokay

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last pass for grammar, otherwise LGTM

seunghun1ee and others added 5 commits August 29, 2025 13:59
From Epoxy, Python 3.12 is required for Ansible control host.
Co-authored-by: Alex Welsh <112560678+Alex-Welsh@users.noreply.github.com>
Co-authored-by: Alex Welsh <alex@stackhpc.com>
@Alex-Welsh Alex-Welsh merged commit 7017ed1 into stackhpc/2025.1 Aug 29, 2025
21 checks passed
@Alex-Welsh Alex-Welsh deleted the update-epoxy-upgrade-doc branch August 29, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants