rewrite ovn-fix-chassis-priorities playbook #1925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbezak
force-pushed
the
ovn-chassis-playbook-fix
branch
from
3687102 to
985febf
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the ovn-fix-chassis-priorities.yml playbook by introducing more sophisticated logic to align HA chassis priorities based on gateway chassis priorities, resolving a potential bottleneck from the previous implementation. The new approach, which uses an inline shell script with a dry-run mode, is a solid enhancement. I've provided a couple of suggestions to further improve the correctness and robustness of the script.
It is now aligning the HA chassis priorities based on gateway chassis ones. Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
bbezak
force-pushed
the
ovn-chassis-playbook-fix
branch
from
985febf to
2be3fd2
Compare
mnasiadka
reviewed
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now aligning the HA chassis priorities based on gateway chassis ones.