-
Notifications
You must be signed in to change notification settings - Fork 23
Adds a Rocky 8 AIO test #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds Rocky 8 pulp repositories to dnf.yml This configures the hosts to use the mirrors in the local pulp. Prior to this change kayobe would attempt to configure CentOS stream mirrors on a Rocky host. * Use facts to pick dnf repositories
* Adds Rocky 8 repository config for local pulp We support Rocky 8 as a host OS with os_distribution == 'rocky'. This adds the configuration necessary to use the RPM snapshots from ark. * Abstract over version number v1 Unsure if it would be better to: 1) Update the remote on the repository 2) Change the publication to point to a new repository and keep repositories for every minor version Advantages of 1: - Single repository in pulp Advantages of 2: - Less chance of conflicts (although I think an old repo is just an old snapshot) * Fixups * Address code review comment Upadting variable name after feedback
This is the equivalent change of: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/831642
183ce05
to
f021ffb
Compare
The kayobe docker image fron kayobe-automation was being built without Rocky Linux support. This is because os_distribution was not being set add build time.
The PR has now been merged.
The images on smslab are now based on centos-minimal.
jovial
commented
Nov 15, 2022
This allows you to differentiate the artifacts across the distros.
jovial
added a commit
to stackhpc/stackhpc-release-train
that referenced
this pull request
Nov 15, 2022
In my PR to add the rocky all in one, I've changed the job name to include the OS distribution (we are now testing more than one): stackhpc/stackhpc-kayobe-config#194 This updates the required checks to match.
markgoddard
reviewed
Nov 16, 2022
This is no longer necessary now the centos image also uses cloud-user.
200G was only necessary for testing the DIB images from kayobe-config with the default LVM logical volume sizes.
markgoddard
reviewed
Nov 17, 2022
849514d
to
62bc328
Compare
62bc328
to
8b906b3
Compare
markgoddard
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.