Skip to content

Yoga AUFN test environment #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jan 19, 2023
Merged

Yoga AUFN test environment #234

merged 33 commits into from
Jan 19, 2023

Conversation

sd109
Copy link
Member

@sd109 sd109 commented Nov 17, 2022

No description provided.

markgoddard
markgoddard suggested changes Nov 17, 2022
View reviewed changes
@sd109
Copy link
Member Author

sd109 commented Nov 17, 2022

Are there any more changes that need made before I try testing this?

@sd109 sd109 requested a review from markgoddard November 17, 2022 12:01
markgoddard
markgoddard suggested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better

@sd109 sd109 requested a review from markgoddard November 17, 2022 13:17
markgoddard
markgoddard reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, give it a whirl.

markgoddard
markgoddard suggested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract the non-AUFN bits please

markgoddard
markgoddard suggested changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review. If you rebase your changes onto stackhpc/xena, it should pick up the bits you extracted.

markgoddard
markgoddard reviewed Dec 19, 2022
View reviewed changes
sd109
sd109 commented Jan 10, 2023
View reviewed changes
@sd109 sd109 requested a review from markgoddard January 11, 2023 12:31
@sd109
Copy link
Member Author

sd109 commented Jan 11, 2023

I think this is now ready to go.

@sd109 sd109 marked this pull request as ready for review January 11, 2023 14:12
@sd109 sd109 requested a review from a team as a code owner January 11, 2023 14:12
markgoddard
markgoddard previously approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Scott. I rebased the change to remove the commits that were pulled out into separate PRs. I pushed your original branch to yoga-aufn-og in case you wanted to compare.

@markgoddard
Copy link
Contributor

Looks like there are some pep8 issues: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/3904414510/jobs/6670166003

@markgoddard
Copy link
Contributor

Could you add some basic docs in doc/source/contributor/environments/aufn-ceph.rst? It can be in a separate PR

@markgoddard
Copy link
Contributor

Seems we have some pep8 failures

@sd109
Copy link
Member Author

sd109 commented Jan 18, 2023

How do I fix the final pep8 issue? It's complaining about {% if ... %} syntax in a yaml file.

Will add some docs separately here: https://github.com/stackhpc/stackhpc-kayobe-config/tree/yoga-aufn-docs

@sd109 @markgoddard
Update etc/kayobe/environments/aufn-ceph/kolla/config/bifrost/bifrost…
92eb7bb 
….yml

Co-authored-by: Mark Goddard <mark@stackhpc.com>
@sd109 sd109 requested a review from markgoddard January 19, 2023 15:08
markgoddard
markgoddard approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@markgoddard
Copy link
Contributor

How do you feel about squashing the commits? Are they useful to keep separate?

@markgoddard
Copy link
Contributor

How do you feel about squashing the commits? Are they useful to keep separate?

(Merge pull request is a drop down)

@sd109 sd109 merged commit 0376526 into stackhpc/yoga Jan 19, 2023
@sd109 sd109 deleted the yoga-aufn branch January 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@markgoddard markgoddard markgoddard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sd109 @markgoddard