Switch to using absolute limit for low memory alert #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodes with alot of ram can end up triggering this low memory alert even when they have a significant amount of free memory e.g for a node with 512GiB ram, when we hit the current alert (which is con figured to be 80%) we still have 102.5GiB free.
priteau
requested changes
Nov 24, 2022
priteau
reviewed
Nov 24, 2022
etc/kayobe/kolla/globals.yml
Outdated
| es_heap_size: 8g | ||
| prometheus_cmdline_extras: "--storage.tsdb.retention.time=30d" | ||
| # Threshold to trigger a LowMemory alert in Gibibytes (GiB). When the | ||
| # amount of free memory is lower that this value an alert will |
priteau
requested changes
Nov 24, 2022
etc/kayobe/kolla/globals.yml
Outdated
| # Threshold to trigger a LowMemory alert in Gibibytes (GiB). When the | ||
| # amount of free memory is lower that this value an alert will | ||
| # be triggered. | ||
| alertmanager_low_memory_threshold_gb: 5 |
There was a problem hiding this comment.
Should we use gib instead of gb?
There was a problem hiding this comment.
Good idea, I've changed it.
jovial
commented
Nov 25, 2022
dougszumski
approved these changes
Nov 25, 2022
markgoddard
approved these changes
Nov 28, 2022
Merged
|
we're using RAW statement in the beginning of the file, therefore this change is not enough
|
|
we could probably add endraw/raw between this new variable @jovial but then, it should probably be a kayobe var, not k-a |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes with alot of ram can end up triggering this low memory alert even when they have a significant amount of free memory e.g for a node with 512GiB ram, when we hit the current alert (which is configured to be 80%) we still have 102.5GiB free.