Add cephadm_commands placeholder variable #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for this feature was added in #290. This adds a variable and some documentation to raise awareness of its existence.
markgoddard
suggested changes
Jan 10, 2023
mnasiadka
reviewed
Jan 11, 2023
doc/source/configuration/cephadm.rst
Outdated
| # A list of commands to pass to cephadm shell -- ceph. See stackhpc.cephadm.commands | ||
| # for format. | ||
| cephadm_commands: | ||
| - "fs new cephfs cephfs_metadata cephfs_data" |
There was a problem hiding this comment.
I would argue that's a good example, changing placement should rather be done using cephadm role, not the commands role.
There was a problem hiding this comment.
That is the example from the docs in the collection. I was going to use this approach to do:
ceph config set mgr mgr/prometheus/server_addr 10.0.0.1
So it wasn't bound to all interfaces. Is that a better example?
EDIT: Assuming you meant not a good example
There was a problem hiding this comment.
Yes, an mgr var is a good example :-) I meant the old one is NOT a good example.
There was a problem hiding this comment.
Thanks, makes sense to not encourage a bad pattern of usage.
Co-authored-by: Mark Goddard <mark@stackhpc.com>
Updating the example based on feedback from the code review. The previous example applied configuration that would have been better applied using the cephadm role. We don't want to encourage such usage.
Merged
markgoddard
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for this feature was added in #290. This adds a variable and some documentation to raise awareness of its existence.