Configure TLS for local Pulp #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bull
force-pushed
the
local-pulp-tls
branch
from
ede2567 to
15eec6c
Compare
* Sets kolla_docker_registry_insecure to true We currently don't configure TLS for the the local pulp registry. This adds the pulp server to the list of insecure-registries, so that we can pull images. * Remove kolla_docker_registry_insecure override in CI environment Based on comments in code review. * Use a better default for kolla_docker_registry_insecure Hoping this will prevent breakage for people already running pulp with TLS. (cherry picked from commit 78055cf)
m-bull
force-pushed
the
local-pulp-tls
branch
from
15eec6c to
0ab0acb
Compare
markgoddard
suggested changes
Jan 24, 2023
etc/kayobe/pulp.yml
Outdated
| # Base URL of the local Pulp service. | ||
| # Default uses the seed node's IP on the admin network. | ||
| pulp_url: "http://{{ admin_oc_net_name | net_ip(groups['seed'][0]) }}:80" | ||
| pulp_url: "{{ 'https' if pulp_enable_tls else 'http' }}://{{ admin_oc_net_name | net_ip(groups['seed'][0]) }}:80" |
There was a problem hiding this comment.
Suggested change
| pulp_url: "{{ 'https' if pulp_enable_tls else 'http' }}://{{ admin_oc_net_name | net_ip(groups['seed'][0]) }}:80" | |
| pulp_url: "{{ 'https' if pulp_enable_tls | bool else 'http' }}://{{ admin_oc_net_name | net_ip(groups['seed'][0]) }}" |
There was a problem hiding this comment.
I'm assuming it switches to 443 when using TLS? If not, should it?
There was a problem hiding this comment.
Good one, thanks. Added pulp_port and a default setting.
|
Is it still a draft? |
markgoddard
reviewed
Feb 1, 2023
markgoddard
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulp_enable_tls.