Skip to content

Conversation

priteau
Copy link
Member

@priteau priteau commented Feb 28, 2023

This fixes a crash seen on HPE DL385 nodes [1]:

panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name

[1] prometheus/node_exporter#2299

@priteau priteau requested a review from a team as a code owner February 28, 2023 15:06
@priteau priteau self-assigned this Feb 28, 2023
cityofships
cityofships previously approved these changes Feb 28, 2023
Copy link
Member

@cityofships cityofships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre

markgoddard
markgoddard previously approved these changes Mar 1, 2023
@technowhizz
Copy link
Contributor

technowhizz commented Mar 10, 2023

Is this safe to be merged @priteau ?

@priteau
Copy link
Member Author

priteau commented Mar 10, 2023

Is this safe to be merged @priteau ?

We should really test it first before rolling it out to everyone.

@technowhizz
Copy link
Contributor

Tested the update and is working as expected!

priteau and others added 2 commits March 15, 2023 21:33
This fixes a crash seen on HPE DL385 nodes [1]:

    panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name

[1] prometheus/node_exporter#2299
@priteau priteau force-pushed the bump-node-exporter branch from 6395560 to ee98ed9 Compare March 15, 2023 20:34
@priteau priteau merged commit ddb6c26 into stackhpc/xena Mar 16, 2023
@priteau priteau deleted the bump-node-exporter branch March 16, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants