Skip to content

Fix temperature graph on hardware overview dash #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix temperature graph on hardware overview dash #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions etc/kayobe/kolla/config/grafana/dashboards/openstack/hardware_overview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@
},
"editorMode": "code",
"exemplar": false,
"expr": "smartmon_temperature_case_raw_value{instance=~\"$node\"}",
"expr": "smartmon_temperature_case_raw_value{instance=~\"$node\"} or smartmon_temperature_celsius_raw_value{instance=~\"$node\"}",
"format": "table",
"hide": false,
"instant": true,
Expand Down Expand Up @@ -664,7 +664,7 @@
},
"editorMode": "code",
"exemplar": false,
"expr": "avg_over_time(smartmon_temperature_case_raw_value{instance=~\"$node\"}[1h])",
"expr": "avg_over_time(smartmon_temperature_case_raw_value{instance=~\"$node\"}[1h]) or avg_over_time(smartmon_temperature_celsius_raw_value{instance=~\"$node\"}[1h])",
"instant": false,
"interval": "",
"legendFormat": "{{instance}} - {{disk}} - {{serial_number}}",
Expand Down Expand Up @@ -752,4 +752,4 @@
"version": 5,
"weekStart": ""
}
{% endraw %}
{% endraw %}
7 changes: 7 additions & 0 deletions releasenotes/notes/fix-hardware-overview-dashboard-temp-ecc047ba46305668.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
fixes:
- |
Fixes the hardware overview dashboard to use the correct metric for
displaying drive temps. Now uses an `or` to display whichever metric
is compatible with the drives in the system. The two metrics are
temperature_case_raw_value and temperature_celsius_raw_value.