-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for manila in multinode #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently not fully tested |
c804de7
to
c0a5c28
Compare
markgoddard
suggested changes
Mar 29, 2023
etc/kayobe/environments/ci-multinode/inventory/group_vars/seed/network-interfaces
Outdated
Show resolved
Hide resolved
a9e3f3c
to
6bf546f
Compare
markgoddard
suggested changes
Mar 29, 2023
Supports Manila in the ci-multinode environment using the CephFS native backend. Configuration is automatic based on the Kolla variables to enable manila and the backend. Also moves cephadm-commands to run after other tasks so that the commands can reference objects created earlier on.
8f85e73
to
62b973d
Compare
62b973d
to
37d5671
Compare
a4adbd7
to
fac75e2
Compare
Split `cephadm_commands` into `cephadm_commands_pre` and `cephadm_commands_post` commands. This allows the user to run commands that must be executed before the rest of the post-deployment configuration, as well as commands that rely on resources created by the post-deployment config.
fac75e2
to
92a30f0
Compare
markgoddard
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs bits could be a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Manila in the ci-multinode environment using the CephFS native backend. Configuration is automatic based on the Kolla variables to enable manila and the backend.