Disable custom apt config for non-overcloud hosts #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
reviewed
Nov 1, 2023
There was a problem hiding this comment.
I'm looking at this in etc/kayobe/kolla/globals.yml and thinking the Debian part is wrong (and should be removed):
# To work around issue of trying to install docker from
# empty pulp server, use upstream docker dnf repo on
# non-overcloud hosts
enable_docker_repo: "{% raw %}{{ 'overcloud' not in group_names or ansible_facts.os_family == 'Debian' }}{% endraw %}"
We include a docker repo in etc/kayobe/apt.yml for overcloud hosts, so don't need Kolla Ansible to install one.
non-overcloud hosts e.g. the seed hypervisor are configured before the seed and its services are deployed. This means that they will look for the local package repo mirrors before they exist.
Alex-Welsh
force-pushed
the
non-overcloud-apt-conf-yoga
branch
from
0893ac6 to
9a348c5
Compare
Good point, I guess that just got missed when we enabled apt repo mirroring again |
markgoddard
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-overcloud hosts e.g. the seed hypervisor are configured before the seed and its services are deployed. This means that they will look for the local package repo mirrors before they exist.