Skip to content

Set OpenSearch heap size #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2024
Merged

Set OpenSearch heap size #886

merged 1 commit into from
Jan 19, 2024

Conversation

priteau
Copy link
Member

@priteau priteau commented Jan 19, 2024

This is required for deployments using Rocky Linux 9. Without this
setting, OpenSearch would set heap size to 1 GB by default, which can
trigger alerts on production systems.

@priteau priteau requested a review from a team as a code owner January 19, 2024 10:43
@priteau priteau self-assigned this Jan 19, 2024
grzegorzkoper
grzegorzkoper previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@grzegorzkoper grzegorzkoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Alex-Welsh
Alex-Welsh previously approved these changes Jan 19, 2024
View reviewed changes
@priteau priteau dismissed stale reviews from Alex-Welsh and grzegorzkoper via 1d89637 January 19, 2024 10:51
JohnGarbutt
JohnGarbutt previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, this is very important.

(its a shame we don't default the openserach_heap_size to the es_heap_size upstream)

JohnGarbutt
JohnGarbutt reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a release note, this is quite a big deal and might require people to review their overrides?

markgoddard
markgoddard previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should have done this in kolla-ansible

@priteau
Set OpenSearch heap size
313faf3 
This is required for deployments using Rocky Linux 9. Without this
setting, OpenSearch would set heap size to 1 GB by default, which can
trigger alerts on production systems.
@priteau priteau dismissed stale reviews from markgoddard and JohnGarbutt via 313faf3 January 19, 2024 10:58
@priteau priteau merged commit ec8ef4f into stackhpc/yoga Jan 19, 2024
@priteau priteau deleted the os-heap-size branch January 19, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorzkoper grzegorzkoper Awaiting requested review from grzegorzkoper

@Alex-Welsh Alex-Welsh Awaiting requested review from Alex-Welsh

@JohnGarbutt JohnGarbutt Awaiting requested review from JohnGarbutt

1 more reviewer

@markgoddard markgoddard markgoddard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@priteau priteau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@priteau @JohnGarbutt @markgoddard @grzegorzkoper @Alex-Welsh