Skip docker registry login by default, login only when pulp is deployed #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
markgoddard
suggested changes
Jan 24, 2024
MoteHue
force-pushed
the
pulp-post-deploy-login
branch
from
97f5e34 to
740e90e
Compare
MoteHue
force-pushed
the
pulp-post-deploy-login
branch
from
740e90e to
ac809cb
Compare
markgoddard
reviewed
Jan 24, 2024
Yes it's untested |
MoteHue
commented
Mar 6, 2024
Alex-Welsh
reviewed
Mar 6, 2024
Have now tested, it works. |
Alex-Welsh
approved these changes
Mar 6, 2024
markgoddard
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.