Skip to content

Deprecate network configuration in environments #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2024
Merged

Deprecate network configuration in environments #920

merged 2 commits into from
Feb 21, 2024

Conversation

assumptionsandg
Copy link
Contributor

No description provided.

@assumptionsandg assumptionsandg mentioned this pull request Feb 7, 2024
Closed
@assumptionsandg assumptionsandg marked this pull request as ready for review February 7, 2024 17:12
@assumptionsandg assumptionsandg requested a review from a team as a code owner February 7, 2024 17:12
markgoddard
markgoddard approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@markgoddard markgoddard reopened this Feb 21, 2024
@markgoddard markgoddard merged commit b189927 into stackhpc/yoga Feb 21, 2024
@markgoddard markgoddard deleted the remove-network-config branch February 21, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@assumptionsandg @markgoddard