Add sufficient detail the the app creds fixes #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Welsh
approved these changes
Feb 12, 2024
Alex-Welsh
previously approved these changes
Feb 12, 2024
Specify that app creds in Yoga are affected by the lack of implicit roles, so no assumptions are made that a system is safe if it is a relatively new deployment. Add a note to the issue of implicit reader roles seen at Bristol Uni. Add instructions on how to add the reader role to existing app creds, taken from Slack conversations
MoteHue
force-pushed
the
secure-rbac-reader-role-changes-needed
branch
from
3017ef9 to
f535c84
Compare
Alex-Welsh
approved these changes
Feb 13, 2024
markgoddard
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify that app creds in Yoga are affected by the lack of implicit roles, so no assumptions are made that a system is safe if it is a relatively new deployment.
Add a note to the issue of implicit reader roles seen at Bristol Uni.
Add instructions on how to add the reader role to existing app creds, taken from Slack conversations